-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/tests on release #1141
Merged
Merged
Fix/tests on release #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KentHsu <[email protected]> Signed-off-by: Alice Gibbons <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
Signed-off-by: Mike Nguyen <[email protected]>
mikeee
commented
Jan 22, 2025
Signed-off-by: Mike Nguyen <[email protected]>
msfussell
approved these changes
Jan 22, 2025
Drafting until the python workflow qs issue source is identified |
mikeee
force-pushed
the
fix/tests-on-release
branch
from
January 22, 2025 22:32
620e136
to
878ca0f
Compare
paulyuk
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Python test failure is not caused by this, but rather SDK/runtime issue here: dapr/python-sdk#745
This was referenced Jan 22, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: